Fix sign comparison issue (Issue #993)

stan-dev · Sep 12, 2018 · 4994c17 · 4994c17
1 parent 1fd117d
commit 4994c17
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/stan/math/prim/mat/fun/promote_double_to.hpp b/stan/math/prim/mat/fun/promote_double_to.hpp
@@ -23,21 +23,19 @@ auto promote_double_to_impl(
     const T_inputs&... inputs);
 template <typename T, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const std::vector<double>& leading_input,
-                                   const T_inputs&... inputs);
+                            const std::vector<double>& leading_input,
+                            const T_inputs&... inputs);
 template <typename T, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const double& leading_input,
-                                   const T_inputs&... inputs);
+                            const double& leading_input,
+                            const T_inputs&... inputs);
 template <typename T, typename R, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const R& leading_input,
-                                   const T_inputs&... inputs);
+                            const R& leading_input, const T_inputs&... inputs);
 
 template <typename T, typename R, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const R& leading_input,
-                                   const T_inputs&... inputs) {
+                            const R& leading_input, const T_inputs&... inputs) {
   return promote_double_to_impl<T>(output, inputs...);
 }
 
@@ -58,11 +56,11 @@ auto promote_double_to_impl(
 
 template <typename T, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const std::vector<double>& leading_input,
-                                   const T_inputs&... inputs) {
+                            const std::vector<double>& leading_input,
+                            const T_inputs&... inputs) {
   std::vector<T> promoted_leading_input;
   promoted_leading_input.reserve(leading_input.size());
-  for (int i = 0; i < leading_input.size(); ++i)
+  for (size_t i = 0; i < leading_input.size(); ++i)
     promoted_leading_input.push_back(leading_input[i]);
   return promote_double_to_impl<T>(
       std::tuple_cat(output, std::make_tuple(promoted_leading_input)),
@@ -71,8 +69,8 @@ auto promote_double_to_impl(std::tuple<T_output...> output,
 
 template <typename T, typename... T_output, typename... T_inputs>
 auto promote_double_to_impl(std::tuple<T_output...> output,
-                                   const double& leading_input,
-                                   const T_inputs&... inputs) {
+                            const double& leading_input,
+                            const T_inputs&... inputs) {
   return promote_double_to_impl<T>(
       std::tuple_cat(output, std::make_tuple(T(leading_input))), inputs...);
 }
@@ -88,9 +86,11 @@ auto promote_double_to_impl(std::tuple<T_output...> output,
  */
 template <typename T, typename... T_inputs>
 auto promote_double_to(const std::tuple<T_inputs...>& input) {
-  return apply([](auto ...lambda_args) {
-      return promote_double_to_impl<T>(std::tuple<>(), lambda_args...);
-    }, input);
+  return apply(
+      [](auto... lambda_args) {
+        return promote_double_to_impl<T>(std::tuple<>(), lambda_args...);
+      },
+      input);
 }
 
 }  // namespace math