Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease jumbo size for windows #2394

Merged
merged 1 commit into from Feb 26, 2021
Merged

Decrease jumbo size for windows #2394

merged 1 commit into from Feb 26, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary

Decreases jumbo size for Windows tests to fix the issue with too big tests files:


C:/rtools40/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.3.0/../../../../x86_64-w64-mingw32/bin/as.exe: test/unit/math/mix/fun_10_test.o: section .pdata$_ZN4stan4math8internal24finite_diff_hessian_autoIZZNS_4test8internal16expect_ad_helperIZN19lub_constrain_tests10expect_vecISt6vectorIN5Eigen6MatrixIdLin1ELin1ELi0ELin1ELin1EEESaISB_EESB_SD_EEvRKT_RKT0_RKT1_EUlSG_SJ_SM_E0_ZNS4_13expect_ad_vvvISN_SD_SB_SD_EEvRKNS3_13ad_tolerancesESG_SJ_SM_RKT2_EUlSG_E0_JSD_SB_SD_EEEvSR_SG_SJ_RKNSA_IdLin1ELi1ELi0ELin1ELi1EEEDpT1_ENKUliE_clEiEUlSG_E_EEvSG_SY_RdRSW_RSB_: string table overflow at offset 10000158

C:\Users\Administrator\AppData\Local\Temp\ccY4ffr6.s: Assembler messages:

C:\Users\Administrator\AppData\Local\Temp\ccY4ffr6.s: Fatal error: can't close test/unit/math/mix/fun_10_test.o: file too big

mingw32-make: *** [<builtin>: test/unit/math/mix/fun_10_test.o] Error 1

mingw32-make: *** Waiting for unfinished jobs....

Tests

/

Side Effects

/

Checklist

  • Math issue #(issue number)

  • Copyright holder: Rok Češnovar

@rok-cesnovar
Copy link
Member Author

Started jenkins tests so they also run windows tests on this PR. They passed so this is ready for review.

Copy link
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Unless the tests fail, then not good

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.49 3.47 1.01 0.79% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -0.63% slower
eight_schools/eight_schools.stan 0.11 0.11 0.99 -0.87% slower
gp_regr/gp_regr.stan 0.17 0.16 1.04 3.93% faster
irt_2pl/irt_2pl.stan 5.23 5.32 0.98 -1.72% slower
performance.compilation 89.89 88.95 1.01 1.05% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.66 8.61 1.01 0.57% faster
pkpd/one_comp_mm_elim_abs.stan 29.51 30.4 0.97 -3.02% slower
sir/sir.stan 131.85 131.38 1.0 0.35% faster
gp_regr/gen_gp_data.stan 0.04 0.05 0.94 -6.56% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.0 3.04 0.99 -1.2% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.39 0.38 1.04 3.66% faster
arK/arK.stan 1.78 1.79 1.0 -0.26% slower
arma/arma.stan 0.7 0.75 0.94 -6.67% slower
garch/garch.stan 0.57 0.56 1.01 1.07% faster
Mean result: 0.994525076711

Jenkins Console Log
Blue Ocean
Commit hash: 437350f


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@bbbales2 bbbales2 merged commit 1bbf76c into develop Feb 26, 2021
@rok-cesnovar rok-cesnovar deleted the windows_jumbo branch February 26, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants