-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Backport Eigen changes for proposed plugin refactor #2654
Conversation
…s/math into backport-plugin-testing
@serban-nicusor-toptal there's a git failure in the downstream cmdstan tests for this PR, would you be able to take a look when you get a minute? |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
hey @andrjohns I hope it works just fine after fixing the conflicts, tbh I think it was just a network error :( Edit: Looks like |
# Conflicts: # stan/math/rev/core/var.hpp # stan/math/rev/core/vari.hpp
Great, thanks! |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Closing for now to clear PR backlog, will re-open once ready for review |
Summary
This PR is for testing that the backported Eigen changes mentioned in #2653 will allow the proposed Eigen plugin refactor (fixing issues with
val
vsval_op
) originally from #2604This PR is for testing downstream compatibility only and should not be merged. Once all errors are fixed, the backported Eigen code and the plugin refactor will be proposed in separate PRs