Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi student t cholesky derivatives #2990

Merged
merged 20 commits into from
Mar 23, 2024
Merged

Conversation

spinkney
Copy link
Collaborator

Summary

This adds derivatives for the multi_student_t_cholesky_lpdf.

Tests

Added a mix test.

Side Effects

No.

Release notes

Adds derivatives for the multi_student_t_cholesky_lpdf

Checklist

  • Copyright holder: Sean Pinkney

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Comment on lines 164 to 165
matrix_partials_t L_deriv(num_dims, num_dims);
L_deriv.setZero();
Copy link
Collaborator Author

@spinkney spinkney Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveBronder I couldn't find a way to conditionally create this partial matrix. I wanted to do something like

const auto& L_deriv
        = to_ref_if<include_summand<propto, T_covar_elem>::value>(Eigen::MatrixXd::Zero(num_dims, num_dims));

Since this matrix only needs to get created when that condition passes. However, I can't just wrap it in a conditional because Eigen complains that the matrix isn't available further down the code in the loop.

@SteveBronder
Copy link
Collaborator

@spinkney is this ready for review?

@spinkney
Copy link
Collaborator Author

spinkney commented Jan 4, 2024

@spinkney is this ready for review?

Yep!

SteveBronder
SteveBronder previously approved these changes Feb 15, 2024
Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small optionals but overall good!


for (size_t i = 1, size_mvt_y = num_y; i < size_mvt_y; i++) {
check_size_match(
function, "Size of one of the vectors of the random variable",
y_vec[i].size(), "Size of another vector of the random variable",
y_vec[i].size(), "Size of the first vector of the random variable",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the previous one? I think leaving it as another would be good

Comment on lines 129 to 131
if (unlikely(num_dims == 0)) {
return T_return(0);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this up to just check this right after declaring num_dims

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved merge conflicts with develop and applied @SteveBronder's suggestions, will merge when tests pass

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.19 0.2 0.95 -5.07% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.99 -1.35% slower
gp_regr/gen_gp_data.stan 0.02 0.02 1.06 5.31% faster
gp_regr/gp_regr.stan 0.11 0.1 1.07 6.22% faster
sir/sir.stan 80.42 76.52 1.05 4.84% faster
irt_2pl/irt_2pl.stan 4.37 4.05 1.08 7.12% faster
eight_schools/eight_schools.stan 0.05 0.05 1.01 0.58% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.27 0.26 1.07 6.59% faster
pkpd/one_comp_mm_elim_abs.stan 19.72 18.41 1.07 6.62% faster
garch/garch.stan 0.48 0.47 1.01 0.82% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.88 2.86 1.01 0.91% faster
arK/arK.stan 1.68 1.67 1.0 0.16% faster
gp_pois_regr/gp_pois_regr.stan 2.58 2.57 1.0 0.48% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.52 9.46 1.01 0.63% faster
performance.compilation 181.92 187.86 0.97 -3.26% slower
Mean result: 1.0222887069900253

Jenkins Console Log
Blue Ocean
Commit hash: a1e38b23f053b005fd392cec1e8f55b0f5a2c76f


Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@andrjohns andrjohns merged commit b010193 into develop Mar 23, 2024
8 checks passed
@WardBrian WardBrian deleted the multi-student-t-derivatives branch April 12, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants