Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence unused variable warning in Boost #3018

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

WardBrian
Copy link
Member

Summary

Closes #3017

Tests

None

Side Effects

None

Release notes

Silenced an unused variable warning in Boost.

Checklist

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@andrjohns
Copy link
Collaborator

I've opened a PR upstream with a different fix: boostorg/math#1078

Which is just changing the assert to:

      BOOST_MATH_ASSERT(
         std::numeric_limits<T>::epsilon() < a
         && a < std::numeric_limits<T>::infinity());

I'm happy to either approve and merge this DISABLE_ASSERTS approach now, or wait until upstream comments on that fix and use that instead, just let me know

@WardBrian
Copy link
Member Author

Either seems fine with me

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to merge this while I sort out some quirks with the upstream PR

@andrjohns andrjohns merged commit 967e86d into develop Feb 1, 2024
8 checks passed
@WardBrian WardBrian deleted the fix/silence-boost-warning branch April 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost unused variable warning
2 participants