-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 breaking changes #3050
5.0 breaking changes #3050
Conversation
…e-move-semantics' into feature/reverse-mode-move-semantics
…e-move-semantics' into feature/reverse-mode-move-semantics
…e-move-semantics' into feature/reverse-mode-move-semantics
…de-move-semantics
…-dev/math into feature/reverse-mode-move-semantics
…de-move-semantics
@syclik should we also remove the |
…ics' into feature/reverse-mode-move-semantics
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Definitely! Let me see what's left on the 5.0 branch. |
(I think the answer is all of them are still on the branch.) |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
…ntics Allow arena_matrix to use move semantics
@syclik the release is finished. Should we merge this once all the tests pass? |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Yes! We should! |
Cool! Since I opened the PR can you approve? |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I spot-checked the code and it looks just as I expected it to be (from previous reviews).
@SteveBronder, thank you for shepherding this PR all the way through to completion!
@SteveBronder, I'm going to merge the PR now just so we can get it flowing through the automatic testing on |
Summary
Ongoing 5.0 branch that contains breaking changes. This should be merged after the coming release so we have a whole release cycle to track down any possible bugs
Contains:
Add any PRs to the above that should be in the 5.0 release
Release notes
Updates Stan math to 5.0
Checklist
Copyright holder: Simon's Foundation, Daniel Lee, Sean Pinkney
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested