Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/0370 remove math.h dependency for C99/C++11 functions #395

Merged
merged 33 commits into from Oct 4, 2016

Conversation

bob-carpenter
Copy link
Contributor

@bob-carpenter bob-carpenter commented Sep 20, 2016

Submisison Checklist

  • Run unit tests: ./runTests.py test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary:

Remove all math.h and top-level namespace dependencies and remove all ifdefs for MSVC with namespace-level using of top-level includes.

Intended Effect:

Unify code, remove math.h top-level namespaces, and pave the way for vectorizing the remaining functions.

How to Verify:

Unit tests still pass. More unit tests for new primitive functions.

Side Effects:

Requires updates to stan-dev/stan to qualify the new functions rather than namespace using statements.

Documentation:

Added doc to functions that needed it.

Reviewer Suggestions:

Anyone.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Bob Carpenter and others added 30 commits August 31, 2016 13:36
@bob-carpenter bob-carpenter changed the title Feature/0370 cp11 cmath funs 2 Feature/0370 remove math.h for C99/C++11 functions Sep 20, 2016
@bob-carpenter bob-carpenter changed the title Feature/0370 remove math.h for C99/C++11 functions Feature/0370 remove math.h dependency for C99/C++11 functions Sep 20, 2016
Copy link
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@syclik syclik added this to the v2.12.0++ milestone Oct 3, 2016
@syclik syclik merged commit dfbb651 into develop Oct 4, 2016
@syclik syclik deleted the feature/0370-cp11-cmath-funs-2 branch October 4, 2016 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants