New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust rvar S4 class definition #267
Comments
@lionel- With a quick test, I do wonder how future-proof that is though. If some future extension writes S4 code that supports vctrs, rvar would not be able to take advantage. With some quick testing, I am pretty sure One downside to that setup is probably that the S4 superclass of |
I have not enough experience with S4 classes so I just leave the decision of what to do up to you @mjskay |
The solution to #269 is going to be to drop |
From a discussion on {jsonlite} (below), we may need to change the S4 class def of rvar to avoid redefining the S4 class definition of vctrs_vctr. See comment:
Would the following work for you? This way you're not declaring anything about our vctrs classes:
setOldClass("rvar")
Just guessing as I don't know much about S4 either.
Originally posted by @lionel- in jeroen/jsonlite#408 (comment)
The text was updated successfully, but these errors were encountered: