Remove "list"
from rvar class definition.
#270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #269 and #267 by removing
"list"
from the end of the class definition ofrvar
. This ensures thatvctrs::vec_is_list(<rvar>)
isFALSE
(fixing some issues with dplyr, closing #269) and ensures that the S4 class definition of"rvar"
does not redefine the S4 parent class of"vctrs_vctr"
to be"list"
(closing #267).Since we already discussed this on #269, once the tests pass here I will merge.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: