Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "list" from rvar class definition. #270

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Remove "list" from rvar class definition. #270

merged 2 commits into from
Feb 2, 2023

Conversation

mjskay
Copy link
Collaborator

@mjskay mjskay commented Feb 2, 2023

Summary

This PR closes #269 and #267 by removing "list" from the end of the class definition of rvar. This ensures that vctrs::vec_is_list(<rvar>) is FALSE (fixing some issues with dplyr, closing #269) and ensures that the S4 class definition of "rvar" does not redefine the S4 parent class of "vctrs_vctr" to be "list" (closing #267).

Since we already discussed this on #269, once the tests pass here I will merge.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@mjskay mjskay merged commit d954973 into master Feb 2, 2023
@mjskay mjskay deleted the new_dplyr branch February 2, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakage due to dplyr 1.10.0
1 participant