Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRAN checks on R devel failing #304

Closed
paul-buerkner opened this issue Oct 29, 2023 · 2 comments · Fixed by #305
Closed

CRAN checks on R devel failing #304

paul-buerkner opened this issue Oct 29, 2023 · 2 comments · Fixed by #305
Milestone
posterior 1.5.0

Comments

@paul-buerkner
Copy link
Collaborator

Brian Ripley send me a very kind email about some CRAN checks failing on R devel:
https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/posterior-00check.html

Specifically, it seems to be some rvar tests. @mjskay would you be so kind to take a look? If you cannot do it within the next week, please let me know so I can fix and resubmit it in time of the usual 2 weeks CRAN notice period.
@paul-buerkner paul-buerkner added this to the posterior 1.5.0 milestone Oct 29, 2023
@mjskay
Copy link
Collaborator

mjskay commented Oct 30, 2023

I'll take a look this week. I also started looking at #300 and found the problem there, just have to fix it.

mjskay added a commit that referenced this issue Oct 30, 2023
@mjskay
future-proof cbind(<rvar>) and rbind(<rvar>) for R 4.4 (#304)
006d1e3
mjskay added a commit that referenced this issue Oct 30, 2023
@mjskay
ensure chol(<rvar>) drops dimnames, for #304
804efab
mjskay added a commit that referenced this issue Oct 30, 2023
@mjskay
fix rvar test for x[NULL] on R 4.4, for #304
b8f7da1
@mjskay mjskay mentioned this issue Oct 30, 2023
Merged
@paul-buerkner
Copy link
Collaborator Author

Thank you for your quick work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
posterior 1.5.0
Development

Successfully merging a pull request may close this issue.

CRAN test fixes for rvar on R 4.4 stan-dev/posterior
2 participants
@mjskay @paul-buerkner