Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure as_draws_rvars preserves dims of length-1 arrays, closes #265 #268

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mjskay
Copy link
Collaborator

@mjskay mjskay commented Jan 25, 2023

Summary

This closes #265 by ensuring that the dimensions of length-1 arrays in are preserved when converted to draws_rvars format.

@wds15 can you verify this solves the problems you had in OncoBayes2? Thanks!

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Merging #268 (7d74707) into master (879bb0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          44       44           
  Lines        3343     3344    +1     
=======================================
+ Hits         3205     3206    +1     
  Misses        138      138           
Impacted Files Coverage Δ
R/as_draws_rvars.R 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wds15
Copy link

wds15 commented Jan 25, 2023

Yes, I can confirm that the example I posted now works just fine with this fix in. Many thanks for fixing it! Looking forward to this getting on CRAN so that OncoBayes2 can be updated as well with a bumped version requirement on posterior.

@paul-buerkner
Copy link
Collaborator

Great! @mjskay merge whenever you like.

@mjskay
Copy link
Collaborator Author

mjskay commented Jan 25, 2023

Great! Thanks again @wds15 for all your thorough testing and bug reporting on rvar, it's really helped!

@mjskay mjskay merged commit 539ec2f into master Jan 25, 2023
@mjskay mjskay deleted the issue-265 branch January 25, 2023 12:42
@wds15
Copy link

wds15 commented Jan 25, 2023

Oh... NP.. thanks for rvar ... I can echo "it really helps"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rvar conversion drops dimensions
4 participants