Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_stat(): hard-coded seed #215

Closed
fweber144 opened this issue Sep 30, 2021 · 1 comment
Closed

get_stat(): hard-coded seed #215

fweber144 opened this issue Sep 30, 2021 · 1 comment

Comments

@fweber144
Copy link
Collaborator

get_stat() has a hard-coded seed:

projpred/R/summary_funs.R

Lines 136 to 138 in 22c61cf

get_stat <- function(mu, lppd, d_test, family, stat, mu.bs = NULL,
lppd.bs = NULL, weights = NULL, alpha = 0.1,
seed = 1208499, B = 2000) {
To my knowledge, such a default is bad practice and should be replaced by seed = NULL. The user has then the responsibility to ensure reproducible results by setting the seed to a specific value.

fweber144 added a commit to fweber144/projpred that referenced this issue Jan 14, 2022
fweber144 added a commit to fweber144/projpred that referenced this issue Jan 14, 2022
AlejandroCatalina pushed a commit that referenced this issue Jan 14, 2022
@fweber144
Copy link
Collaborator Author

Fixed in develop, so a corresponding label may be added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant