Error in case of non-predictor arguments of s() or t2()
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowed, so throw an appropriate error message. This is a follow-up for issue stan-dev#156 which was only concerned with documentation. However, this still does not address stan-dev#238 yet (but at least we now throw an appropriate error message).
fweber144
added a commit
that referenced
this pull request
Mar 22, 2023
fweber144
added a commit
that referenced
this pull request
Mar 22, 2023
fweber144
added a commit
to fweber144/projpred
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #269 (which was based on this comment and the discussion following it in issue #156). PR #269 was only concerned with documenting that in
s()andt2()terms, arguments other than predictors are not allowed. Here, we also throw an appropriate error message. However, this still does not address #238 yet (but at least we now throw an appropriate error message).