Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot.vsel shows extra xtick label #462

Closed
avehtari opened this issue Oct 19, 2023 · 1 comment
Closed

plot.vsel shows extra xtick label #462

avehtari opened this issue Oct 19, 2023 · 1 comment
Assignees

Comments

@avehtari
Copy link
Collaborator

See, e.g., here https://users.aalto.fi/~ave/modelselection/candy.html, there is an extra x tick label 12

image

Another example with a gap before the last tick label
image

Might be related to using text_angle

@avehtari avehtari assigned avehtari and fweber144 and unassigned avehtari Oct 19, 2023
@fweber144
Copy link
Collaborator

Thanks for reporting; fixed now. As far as I can tell, this seemed to be a long-standing bug (I was able to track it down at least until commit b05a8f4), so if you haven't experienced this bug before, then your last version of the candy case study (I think https://github.com/avehtari/modelselection/blob/ad0e10ce7d3a47de560609db7abe83777eed28bc/candy.Rmd is still at the old state) was probably using an even older projpred version. I'm just saying this because I was curious where the bug was introduced and if additional changes would have been necessary. But I think the fix from commit fc5d68f should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants