Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

fix: Update .travis.yml format #19

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

riddell-stan
Copy link
Contributor

No description provided.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ exception is not catched or something similar is going on. When inv file is not defined, it should just skip that part, now it send error to log and crashes in the return step.

env_vars.sh Show resolved Hide resolved
.travis.yml Outdated
- os: linux
env:
- MB_PYTHON_VERSION=2.7
- UNICODE_WIDTH=16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest manylinux2014 has dropped support for 2.7. Not sure about manylinux1.

And 2.7 is eol, and 2.19.1 wheel is in pypi.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of it then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to add a commit for it, or do you want to do it yourself?

@riddell-stan
Copy link
Contributor Author

I'm fairly sure I screwed up and deleted some important patches I had to the default manylinux1 image. IIRC, unpatched multibuild does not build the linux wheels for pystan 2.19.1 due to the old version of gcc.

I'm really sorry about this! I might have time to look at this again after the next pystan 3 beta is out.

@ahartikainen
Copy link
Contributor

These for some reason work

https://travis-ci.org/github/ahartikainen/pystan-wheels/builds/716910572
https://github.com/ahartikainen/pystan-wheels/pull/1/files

TBH not sure what all did I change, but I think I just manually forced manylinux1 (multibuild goes for manylinux2014)

Set docker explicitly to manylinux1.
@ahartikainen
Copy link
Contributor

I added explicit line for manylinux1, let's see if that works.

@ahartikainen
Copy link
Contributor

ahartikainen commented Aug 11, 2020

Everything else but this works

- os: linux
    env:
      - MB_PYTHON_VERSION=2.7
      - UNICODE_WIDTH=16

Reason for this is that pip upgrade fails.

Should we merge this and then decide what to do for py27.

(This pr uploads only wheels for 38)

@riddell-stan
Copy link
Contributor Author

Removed all 2.7 versions and 3.5 too.

@ahartikainen ahartikainen merged commit 5ac8860 into stan-dev:master Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants