Skip to content

Commit

Permalink
chore: Update types for mypy
Browse files Browse the repository at this point in the history
  • Loading branch information
riddell-stan committed Jul 4, 2022
1 parent bf6b1e9 commit 1497c0c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
3 changes: 2 additions & 1 deletion stan/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ class HTTPResponse(typing.NamedTuple):
content: bytes

def json(self) -> dict:
return simdjson.loads(self.content)
# mypy 0.961 complains that simdjson lacks a `loads`.
return simdjson.loads(self.content) # type: ignore


class HttpstanClient:
Expand Down
2 changes: 1 addition & 1 deletion stan/fit.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def __init__(
draw_index = 0
for line in stan_output.splitlines():
try:
msg = parser.parse(line)
msg = cast(simdjson.Object, parser.parse(line))
except ValueError:
# Occurs when draws contain an nan or infinity. simdjson cannot parse such values.
msg = json.loads(line)
Expand Down
7 changes: 4 additions & 3 deletions stan/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json
import re
import time
from typing import Dict, List, Optional, Sequence, Tuple, Union
from typing import Dict, List, Optional, Sequence, Tuple, Union, cast

import httpstan.models
import httpstan.schemas
Expand Down Expand Up @@ -258,11 +258,12 @@ async def go():
stan_outputs = tuple(stan_outputs) # Fit constructor expects a tuple.

def is_nonempty_logger_message(msg: simdjson.Object):
return msg["topic"] == "logger" and msg["values"][0] != "info:"
return msg["topic"] == "logger" and msg["values"][0] != "info:" # type: ignore

def is_iteration_or_elapsed_time_logger_message(msg: simdjson.Object):
# Assumes `msg` is a message with topic `logger`.
text = msg["values"][0]
text = msg["values"][0] # type: ignore
text = cast(str, text)
return (
text.startswith("info:Iteration:")
or text.startswith("info: Elapsed Time:")
Expand Down

0 comments on commit 1497c0c

Please sign in to comment.