Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RStan & expiring deprecations #1056

Open
andrjohns opened this issue Apr 1, 2023 · 5 comments
Open

RStan & expiring deprecations #1056

andrjohns opened this issue Apr 1, 2023 · 5 comments

Comments

@andrjohns
Copy link
Contributor

Transferring the discussion from the forums for visibility.

We're approaching the expiration of deprecated syntax (e.g., arrays) before rstan is compatible with the new syntax and downstream packages can update. The current compromise is to delay the deprecations by a release cycle (four months), with the goal of having 2.26 (and then quickly 2.31/2.32) on CRAN in the near future so that downstream dependencies can begin to update.

We will also have the lee-way of an additional release cycle after the deprecations expire through the use of the stanc auto-formatter. But as mentioned, this will only work for one release cycle after the deprecations expire.

I personally think that this feasible, and am happy to handle most of the PRs patching downstream dependencies. But I'm not familiar enough with rstan's previous/current CRAN difficulties to know whether it's likely to get 2.26+ to CRAN soon, so feedback is appreciated

@jgabry
Copy link
Member

jgabry commented Apr 1, 2023

I personally think that this feasible, and am happy to handle most of the PRs patching downstream dependencies. But I'm not familiar enough with rstan's previous/current CRAN difficulties to know whether it's likely to get 2.26+ to CRAN soon, so feedback is appreciated

Thanks @andrjohns. @bgoodri thoughts on the 2.26+ timeline?

@andrjohns
Copy link
Contributor Author

I followed up with the remaining maintainers from #1053 by email and now only four packages have yet to merge the fixes for their package on Github - three of those (beanz, idem, and visit) also belong to a single maintainer

@andrjohns
Copy link
Contributor Author

@bgoodri Can the StanHeaders submission be made now? I don't believe there's anything more we can do for the downstream packages, but feel free to correct me

@andrjohns
Copy link
Contributor Author

@bgoodri Feels like I'm shouting into the void here, but there are now only four downstream breakages (from two maintainers) under all combinations of 2.21, 2.26, and 2.31 rstan/StanHeaders. These maintainers haven't responded to the PRs or direct email.

Do with that what you will. Or don't. Ball's in your court.

@bgoodri
Copy link
Contributor

bgoodri commented Apr 21, 2023

I hear you. We'll just have to break some packages unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants