Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theme_set() on startup and change message #278

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

malcolmbarrett
Copy link
Contributor

Closes #257

Reflects changes to bayesplot approach to themes in stan-dev/bayesplot#149

Closes stan-dev#257

Reflects changes to `bayesplot` approach to themes in stan-dev/bayesplot#149
@jgabry
Copy link
Member

jgabry commented May 3, 2018

Thanks for this! I’ll review the bayesplot one first and once that’s merged I’ll review/merge this one for rstanarm.

@jgabry
Copy link
Member

jgabry commented May 3, 2018

And don’t worry about Travis-ci errors unless they occur before it times out. But it will probably time out and error even if all is ok, so we’ll have to check it locally.

@malcolmbarrett
Copy link
Contributor Author

malcolmbarrett commented Jun 9, 2018

I'm going to update this to match the bayesplot startup message. This one is much simpler, but anything else that needs to be done before merging? I checked the vignettes that use raw ggplot2, but they seem to be setting the theme to theme_default in the background.

@malcolmbarrett
Copy link
Contributor Author

Although, now that I say it, it makes less sense for the vignettes that have raw ggplot2 to be using theme_default() without explicitly calling it in the code since rstanarm will no longer change the theme for all ggplots.

@bgoodri
Copy link
Contributor

bgoodri commented Mar 20, 2019

@jgabry What is up with this PR?

@jgabry jgabry merged commit b1a0c9b into stan-dev:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants