-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functional/functor testing framework for first- and higher-order autodiff #1141
Comments
Stan-devs should check out my attempt at this in the Nomad repo. On Nov 19, 2014, at 7:04 PM, Bob Carpenter notifications@github.com wrote:
|
It'd be nice if the tests were factored so that the Rob and I just started doing this on a branch
|
What do you mean by Nomad data structure? On Nov 19, 2014, at 9:09 PM, Bob Carpenter notifications@github.com wrote:
|
I don't have the Nomad test code in front of me, but when Rob was I think it'll be easiest and most portable if the tests This is the same point I was trying to make about defining Here's what the test for log1p looks like in the framework
|
https://github.com/stan-dev/nomad/blob/master/src/test/scalar/functions/smooth_functions/acos_test.cpp On Nov 19, 2014, at 11:15 PM, Bob Carpenter notifications@github.com wrote:
|
Cool --- this is great. It's a more mature version of exactly what What we should do is refactor what we have in Stan to use the Nomad I like that it's done on vectors, but Rob and I hadn't Then you need to define multiple functors. I don't offhand You could avoid the hard coding of a single test value by adding the Are you doing the double-double tests elsewhere? I see that you don't have I also like the addition of the name to the functor. You could get around the virtuality of base_functor::operator() if you I keep thinking that function pointers could get rid of the need to
|
This issue was moved to stan-dev/math#51 |
This issue was moved to stan-dev/math#55 |
To remove duplication from our derivative testing code and also make it portable for when we upgrade autodiff, we need to move our testing into a generic functional framework that takes pairs of functors and compares them.
The text was updated successfully, but these errors were encountered: