Specifying maximum number of iterations to be less than eval_elbo

[dustinvtran]

If users currently try to run ./model variational iter=1 data file=model.data, then the algorithm runs on infinitely often or until convergence, rather than stopping after the first iteration. This is because we only check if the current iteration is equal to the maximum number of iterations during ELBO evaluations.

trivial fix will be available in this pull request

[akucukelbir]

yes! i was thinking about this earlier today. great catch.

[dustinvtran]

Oops, sorry, this is a bug only in that pull request. It has nothing to do with eval_elbo and only comes up when max_iters is less than warmup_iterations.