We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As pointed out by @bgoodri on stan-dev list, truncation syntax is generating
if (y < 1) lp_accum__.add(-std::numeric_limits<double>::infinity()); else lp_accum__.add(-poisson_ccdf_log(1, rate));
Instead it should be throwing std::domain_error with a meaningful message.
std::domain_error
Also from @bgoodri:
For
y ~ normal(mu, sigma) T[1,];
then if y < 1, then I think it should exit but if y == 1, then it should throw an non-fatal exception. It is possible that the user wrote
y < 1
y == 1
parameters { real<lower=1> y; ... }
and y just underflows to 1.
y
stan::math
Use truncation with out of bounds.
Nothing---just keeps going and get failure due to -infinity log density.
Appropriate warning message.
v2.11.0
The text was updated successfully, but these errors were encountered:
bob-carpenter
No branches or pull requests
Summary:
As pointed out by @bgoodri on stan-dev list, truncation syntax is generating
Instead it should be throwing
std::domain_error
with a meaningful message.Also from @bgoodri:
For
then if
y < 1
, then I think it should exit but ify == 1
, then it should throw an non-fatal exception. It is possible that the user wroteand
y
just underflows to 1.stan::math
with appropriate boundsReproducible Steps:
Use truncation with out of bounds.
Current Output:
Nothing---just keeps going and get failure due to -infinity log density.
Expected Output:
Appropriate warning message.
Current Version:
v2.11.0
The text was updated successfully, but these errors were encountered: