Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework Metropolis rejection warning #223

Closed
1 of 2 tasks
bob-carpenter opened this issue Sep 19, 2013 · 1 comment · Fixed by #818
Closed
1 of 2 tasks

rework Metropolis rejection warning #223

bob-carpenter opened this issue Sep 19, 2013 · 1 comment · Fixed by #818
Assignees
Milestone

Comments

@bob-carpenter
Copy link
Contributor

We're torn between wanting to leave the reject warnings in to help users diagnose errors and getting rid of them to stop users from freaking out when seeing them.

We also want them to be more informative.

Some specifics:

  • Fix error messages to clarify size mismatches and also hint that they may be the cause of rejection.

    Informational Message: The parameter state is about to be Metropolis
    rejected due to the following underlying, non-fatal (really) issue 
    

    for which I suggest adding

    check that all functions and distributions have consistently sized,
    in-support arguments 
    
  • Fix

    Error in function stan::prob::normal_log(m): Location parameter (max size)
    is 256, but must be consistent, 1 or max=768 
    

    which could be changed to

    a vectorized function was called with arguments of different scalar, array, vector,
    or matrix types, and they were not consistently sized;  all arguments
    must be scalars or multidimensional values of the same shape;  found dimensions=
    <list of argument shapes passed in> 
    
@ghost ghost assigned bob-carpenter Sep 19, 2013
@syclik
Copy link
Member

syclik commented Jul 30, 2014

I'm creating a pull request for the second checkbox. I don't think we should do the first -- I think we should be throwing a different type of error that will stop sampling if the sizes are inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants