Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base_mcmc into crtp? #2848

Open
SteveBronder opened this issue Nov 6, 2019 · 0 comments
Open

Make base_mcmc into crtp? #2848

SteveBronder opened this issue Nov 6, 2019 · 0 comments

Comments

@SteveBronder
Copy link
Collaborator

Summary:

I'm looking at base_mcmc and it looks like it's virtualness is only used in a few functions

run_sampler
generate_transitions
write_adapt_finish

I think we could rewrite that to just be a CRTP class and change those signatures to be like

template <typename Model, typename RNG, typename DerivedMCMC>
void run_sampler(stan::mcmc::base_mcmc<DerivedMCMC>& sampler, Model& model,

Expected Output:

Removal of some dynamic lookup for compile time lookup

Current Version:

v2.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant