Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map_rect #333

Merged
merged 2 commits into from Oct 12, 2019
Merged

Fix map_rect #333

merged 2 commits into from Oct 12, 2019

Conversation

seantalts
Copy link
Member

  • remove the first argument from calls to map_rect even though all other HOFs have the first argument as the function and don't require explicit template arguments
  • add a call_id integer that just increments every time we emit a call to map_rect. I think this was a hack that went in before because we didn't want to modify the old compiler too much; now I'm reproducing that hack in the new compiler in lieu of fixing it because it would require nontrivial changes to Math.

* remove the first argument from calls to map_rect even though all other HOFs have the first argument as the function and don't require explicit template arguments
* add a call_id integer that just increments every time we emit a call to map_rect. I think this was a hack that went in before because we didn't want to modify the old compiler too much; now I'm reproducing that hack in the new compiler in lieu of fixing it because it would require nontrivial changes to Math.
@seantalts seantalts merged commit eb66b27 into master Oct 12, 2019
@WardBrian WardBrian deleted the fix-map-rect branch October 20, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant