Add PostgreSQL DB driver #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
commented
Jun 30, 2019
|
|
||
| $db_name = 'testdatabase' . $this->randomString(10); | ||
| app(DatabaseManager::class)->create($db_name, 'pgsql'); | ||
| $this->assertNotEmpty(DB::select("SELECT datname FROM pg_database WHERE datname = '$db_name'")); |
There was a problem hiding this comment.
Is this a correct way of checking that a database exists?
There was a problem hiding this comment.
It is, but Postgres converts all DB names to lowercase while the WHERE clause does not.
Codecov Report
@@ Coverage Diff @@
## 1.x #52 +/- ##
===========================================
+ Coverage 88.26% 88.4% +0.13%
- Complexity 128 130 +2
===========================================
Files 22 23 +1
Lines 341 345 +4
===========================================
+ Hits 301 305 +4
Misses 40 40
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51