Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made styled components a peer dependency #14

Merged
merged 2 commits into from Dec 10, 2020
Merged

Made styled components a peer dependency #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9e061
Made it a peer dependency and it works
franciscop-sc Dec 10, 2020
c0cfb20
Improved readme getting started
franciscop-sc Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "@standard/portal",
"version": "0.3.5",
"version": "0.3.7",
"description": "Easily add a login portal to any React app with Auth0",
"homepage": "https://github.com/standard-ai/portal#readme",
"bugs": "https://github.com/standard-ai/portal/issues",
Expand All @@ -19,12 +19,11 @@
"stats": "webpack -c --profile --json > webpack-stats.json",
"test": "jest"
},
"dependencies": {
"styled-components": "^5.2.0"
},
"dependencies": {},
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0",
"react-dom": "^16.8.0 || ^17.0.0"
"react-dom": "^16.8.0 || ^17.0.0",
"styled-components": "^5.2.0"
},
"devDependencies": {
"@auth0/auth0-spa-js": "^1.13.0",
Expand All @@ -39,6 +38,7 @@
"react-dom": "^16.8.0 || ^17.0.0",
"react-test": "^0.7.3",
"regenerator-runtime": "^0.13.7",
"styled-components": "^5.2.0",
"use-async-effect": "^2.2.2",
"webpack": "^4.44.2",
"webpack-cli": "^3.1.2"
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Expand Up @@ -43,10 +43,10 @@ export default () => (

## Getting started

This is the _quick guide_ on how to get started. First install this library:
First install this library. You need to install `styled-components` as well if you don't have it yet:

```bash
npm i @standard/portal
npm i @standard/portal styled-components
```

Then provide the Auth0 config as environment variables:
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ module.exports = {
}
},
externals: {
// Don't bundle react
// Don't bundle styled components
"styled-components": {
commonjs: "styled-components",
commonjs2: "styled-components",
Expand Down