Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.4 #300

Merged
merged 38 commits into from
Nov 28, 2019
Merged

Release 0.1.4 #300

merged 38 commits into from
Nov 28, 2019

Conversation

Ainali and others added 30 commits September 19, 2019 14:31
I made a few editorial suggestions in the files of the standard as I was reading through.
Good suggestion.

Co-Authored-By: Elena FdR <ElenaFdR@users.noreply.github.com>
Co-Authored-By: Boris van Hoytema <boris@publiccode.net>
Co-Authored-By: Boris van Hoytema <boris@publiccode.net>
Co-Authored-By: Boris van Hoytema <boris@publiccode.net>
Co-Authored-By: Boris van Hoytema <boris@publiccode.net>
Added license in the metadata of the files
Link to Semantic Versioning Specification in Further reading
While it is implied that code and docs are not required to share a
license, the previous wording could be read in such a way as to
suggest that they MUST.

This commit simplifies the language and removes this possible
mis-reading.
Simplify & avoid 'code and docs under "a" licnese'
fixed a typo and removed a forgotten )
Added periods to all criteria list items that missed it, for consistency
Rewords reference in introduction to remove ambiguity.
"Which" could refer to both the public code as the traditional
model, which can be confusing.

Rewords the example for general public in the glossary. The
previous wording was a bit confusing to me. I had to reread
it a few times before I realized that it aligned with my intuition.

Clarifies that code should be accessible without authorization.
This may be a bit pedantic, but one could imagine codebases which
are secured with a password. That would not require authentication
but would require authorization. Neither seems desirable.

Fixes a minor grammatical issue in the plain English criteria page.

Avoids repetition of document base within a sentence.
Minor phrasing changes in introduction and criteria pages
minor wordsmithing and link added to the license
Copy link
Contributor Author

@ericherman ericherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed all files -- LGTM

Copy link
Contributor

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay Bump!

@ericherman ericherman marked this pull request as ready for review November 28, 2019 12:34
Copy link
Contributor Author

@ericherman ericherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Marcus Klaas de Vries clarified and improved some text as well.

@bvhme bvhme merged commit 187ad10 into master Nov 28, 2019
@bvhme bvhme deleted the release-0.1.4 branch November 28, 2019 14:30
@Ainali Ainali mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants