Upgrade dev dependencies and tests #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
Merged
|
Thanks for the PR @patrikjuvonen 🙏 I built upon it in #40 and merged and released it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was debugging something earlier and did the work to upgrade the dev dependencies and the test while at it.
I used the tests from eslint-config-standard as inspiration: https://github.com/standard/eslint-config-standard/blob/master/test/validate-config.js but I kept the existing code style and structure as my goal was to just make sure it works.
I decided to open this pull request with the changes in case it's helpful 🙂
The upgrade will break on Node 10.
Node 10 has been EOL since end of April 2021.
Node 12 EOL is end of April 2022, so very soon. https://nodejs.org/en/about/releases/
eslint-config-standard uses the
lts/*setup-node action configuration: https://github.com/standard/eslint-config-standard/blob/master/.github/workflows/ci.yml#L15-L18 which should probably put into use in this repository as well. However, that is out of scope for this pull request as such I think.