Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Considering return-await rule #199

Closed
mightyiam opened this issue Dec 24, 2019 · 2 comments · Fixed by #253
Closed

Considering return-await rule #199

mightyiam opened this issue Dec 24, 2019 · 2 comments · Fixed by #253

Comments

@mightyiam
Copy link
Owner

I'd like some input regarding the possible inclusion of the return-await rule, please. I've also asked upstream.
@mightyiam
Copy link
Owner Author

The upstream input (@bradzacher) made good points, I feel.

mightyiam added a commit that referenced this issue Jan 15, 2020
@mightyiam
feat: new rule return-await with in-try-catch
7dbdfa9 
BREAKING CHANGE: new rule return-await with in-try-catch option.

Closes #199.
@mightyiam mightyiam mentioned this issue Jan 15, 2020
Closed
mightyiam added a commit that referenced this issue Jan 17, 2020
@mightyiam
feat: new rule return-await with in-try-catch
4d21190 
BREAKING CHANGE: new rule return-await with in-try-catch option.

Closes #199.
mightyiam added a commit that referenced this issue Jan 30, 2020
@mightyiam
feat: new rule return-await with in-try-catch
22bd821 
BREAKING CHANGE: new rule return-await with in-try-catch option.

Closes #199.
mightyiam added a commit that referenced this issue Mar 17, 2020
@mightyiam
feat: new rule @typescript-eslint/return-await always
216e63b 
BREAKING CHANGE: new rule @typescript-eslint/return-await always

Closes #199.
@mightyiam mightyiam mentioned this issue Mar 17, 2020
Merged
@mightyiam
Copy link
Owner Author

I feel like a decision should be made and the reported debugging benefits of always outweigh potential micro-optimization concerns of it.

mightyiam added a commit that referenced this issue Mar 17, 2020
@mightyiam
feat: new rule @typescript-eslint/return-await always
8b4acc7 
BREAKING CHANGE: new rule @typescript-eslint/return-await always

Closes #199.
@KilianKilmister KilianKilmister mentioned this issue Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mightyiam