BREAKING: make lintText into a sync method #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #156 Before: standardEngine.lintText(text, [opts], callback) After: results = standardEngine.lintText(text, [opts]) If an error occurs, an exception is thrown. Otherwise, a `results` object is returned.
Flet
approved these changes
Feb 21, 2017
|
Great that lands so fast! |
|
Both of the methods are synchronous in ESLint: |
|
@mightyiam yea, i thought to mention that too. |
|
@mightyiam We do extra work on top of what eslint does, and that work is async. |
|
One day ESLint may be asynchronous. And then we'll be breaking again...
…On Tue, Feb 21, 2017, 21:42 Feross Aboukhadijeh ***@***.***> wrote:
@mightyiam <https://github.com/mightyiam> We do extra work on top of what
eslint does, and that work is async.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#157 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAmyx-guWam-z0s0ZZdw-Fl_jPBoU5pXks5rez4OgaJpZM4MG8Pc>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #156
Before:
standardEngine.lintText(text, [opts], callback)After:
results = standardEngine.lintText(text, [opts])If an error occurs, an exception is thrown. Otherwise, a
resultsobject is returned.