Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include package name and version in cache folder name #181

Merged
merged 7 commits into from May 15, 2018
Merged

Include package name and version in cache folder name #181

merged 7 commits into from May 15, 2018

Conversation

feross
Copy link
Member

@feross feross commented May 10, 2018

  • BREAKING: Require opts.cmd and opts.version in Linter()
  • Include package name and version in cache folder name to reduce the likelihood of the issue described in Allow disabling cache #172

Other small changes:

  • Cache process.cwd() in constructor
  • Avoid one new call
  • Remove one unneeded require()

Release this as a major version bump.

Fixes: #172

@feross feross mentioned this pull request May 10, 2018
Closed
@feross feross requested a review from Flet May 10, 2018 02:03
feross added 7 commits May 9, 2018 19:56
@feross
BREAKING: require opts.cmd option
596a4cf 
Let's not default to naming the linter 'standard', as this increases the likelihood that another standard-engine linter variant will end up using the same cache folder name as the real `standard` linter.
@feross
Cache process.cwd() in constructor
d4c2916
@feross
perf: Remove extra require() call
a5fb5ea 
Most of the time the user will be setting the version so it's not worth requiring standard-engine's package.json every time when it's not used
@feross
perf: avoid new getting called internally
d5a87ff 
saves one function call
@feross
BREAKING: require opts.version option
2b34c67
@feross
Use cmd and version in cache folder name
afca0bf 
So for standard, the cache location would be:

  .standard-v12-cache/
@feross
Fix tests
14281aa
@Flet
Copy link
Member

Flet commented May 14, 2018 •
edited

Looks good! 👍

@feross feross merged commit 41d6aff into master May 15, 2018
@feross feross deleted the cache-vesion branch May 15, 2018 08:25
@feross
Copy link
Member Author

feross commented May 15, 2018

9.0.0

@voxpelli voxpelli mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flet Flet Flet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Standard Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feross @Flet