Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & small fixes #220

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Cleanup & small fixes #220

merged 6 commits into from
Apr 30, 2020

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented Apr 30, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: lots of cleanup & small fixes, see each commit for full details

What changes did you make? (Give an overview)

  • Disable package-lock file
    • This file is not applicable for libraries
  • Cleanup package metadata
    • Update repository to new location
    • Use repository shorthand
    • Sort with npx sort-package-json
  • Bump deglob & minimist dependencies
  • Bump all dev-dependencies
    • Also switch from * to ^
  • Test on supported Node.js versions
    • 8.10
    • 10
    • 12
    • 14
  • Fix linting errors in readme

Which issue (if any) does this pull request address?

#213 #218

Is there anything you'd like reviewers to focus on?

everything 馃槄

@LinusU LinusU changed the title Update Cleanup & small fixes Apr 30, 2020
@LinusU LinusU requested a review from toddbluhm April 30, 2020 08:30
Copy link
Contributor

@toddbluhm toddbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!
Glad to see specific node versions being checked in travis 馃帀
Also really like that we are using versions for the dev dependencies now too!

@LinusU LinusU merged commit 64c7a6e into master Apr 30, 2020
@LinusU LinusU deleted the update branch April 30, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants