Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntastic has stopped working with standard@3.0.0-beta4 #65

Closed
othiym23 opened this issue Mar 17, 2015 · 9 comments

Comments

@othiym23
Copy link

commented Mar 17, 2015

Which makes me sad because now it seems like most of the ES6 stuff I use is handled properly. ;_;

I updated Syntactic to HEAD, and have verified that standard is working by running :!standard against an erroneous file from inside vim. If nothing obvious occurs to you about how the formatting might have changed in beta4, I can dig into this more tomorrow.

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2015

Ran into something similar. The fix for me was to use io.js@>=1.

@othiym23

This comment has been minimized.

Copy link
Author

commented Mar 17, 2015

@yoshuawuyts

bauchelain% iojs --version
v1.5.1

This is probably an eslint issue, because the diff between beta3 and beta4 is pretty much entirely the change to eslint@0.17.0.

@othiym23 othiym23 changed the title Syntastic has stopped working with standard@3.0.0-beta.4 Syntastic has stopped working with standard@3.0.0-beta4 Mar 17, 2015

@feross

This comment has been minimized.

Copy link
Member

commented Mar 17, 2015

I can't think of anything that might have caused this, except maybe a change in Syntastic. Does 3.0.0-beta3 work fine with Syntastic HEAD?

@othiym23

This comment has been minimized.

Copy link
Author

commented Mar 18, 2015

Does 3.0.0-beta3 work fine with Syntastic HEAD?

It sure does! I didn't try changing the Syntastic version until after beta4 stopped working, but even then, I can switch between beta3 and beta4 and it starts and stops working accordingly. I really need this to work, so I'm going to dig in a bit further.

@feross

This comment has been minimized.

Copy link
Member

commented Mar 19, 2015

Hey @othiym23, can you try again with v3.2.0? I removed automatic detection of stdin, which is error-prone and may have been confusing Syntastic/vim.

@othiym23

This comment has been minimized.

Copy link
Author

commented Mar 19, 2015

So, to capture here what we discussed on IRC, when I go into bin/cmd.js and comment out the line that sets the default value for stdin to !process.stdin.isTTY, everything starts magically working again. It's probably best to require users to explicitly call --stdin, or follow browserify's lead and observe the Unix convention of using - as the way of indicating that input should come from stdin.

@feross

This comment has been minimized.

Copy link
Member

commented Mar 19, 2015

Yep, that change is already released as 3.2.0!
On Wed, Mar 18, 2015 at 10:11 PM Forrest L Norvell notifications@github.com
wrote:

So, to capture here what we discussed on IRC, when I go into bin/cmd.js
and comment out the line that sets the default value for stdin to
!process.stdin.isTTY, everything starts magically working again. It's
probably best to require users to explicitly call --stdin, or follow
browserify's lead and observe the Unix convention of using - as the way
of indicating that input should come from stdin.


Reply to this email directly or view it on GitHub
#65 (comment).

@feross

This comment has been minimized.

Copy link
Member

commented Mar 19, 2015

Oh, I see you were just clarifying for posterity.

@othiym23

This comment has been minimized.

Copy link
Author

commented Mar 19, 2015

Yep! standard@3.2.0 works again! 🎉

@othiym23 othiym23 closed this Mar 19, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.