Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEvent is not defined with flow type, any way to fix this without ejecting from standard? #984
Comments
This comment has been minimized.
This comment has been minimized.
cgestes
commented
Oct 5, 2017
|
Same issue here. A lot of undefined because of those rules. Any PR in the pipe? |
This comment has been minimized.
This comment has been minimized.
seanng
commented
Oct 19, 2017
|
I'm facing the same problem :( |
This comment has been minimized.
This comment has been minimized.
|
What are the versions of your packages? eslint, flowtype plugin, standard, etc.? It would be great to have a small repo where we could reproduce the issue |
This comment has been minimized.
This comment has been minimized.
fbaiodias
commented
Oct 27, 2017
|
I was having a similar issue, getting a lot of |
This comment has been minimized.
This comment has been minimized.
mcchrish
commented
Nov 7, 2017
|
@fbaiodias your solution works. Thanks |
This comment has been minimized.
This comment has been minimized.
doughsay
commented
Nov 18, 2017
•
|
Downgrading to What's going on here...? EDIT: scratch that... downgrading fixes the problems, the other problems I was having was not prefixing browser globals with |
This comment has been minimized.
This comment has been minimized.
CoenWarmer
commented
Nov 24, 2017
|
Downgrading to Just for my understanding, is this flow type undef behavior due to an an issue with |
This comment has been minimized.
This comment has been minimized.
borismacias
commented
Nov 28, 2017
|
Also work for us with babel-eslint@7.2.1, tried to upgrade to babel-eslint@7.2.3 and it breaks again. |
petemill
added a commit
to brave/browser-laptop
that referenced
this issue
Dec 21, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Dec 22, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Dec 22, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Dec 22, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Dec 22, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Dec 27, 2017
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Jan 4, 2018
This comment has been minimized.
This comment has been minimized.
pietrofxq
commented
Jan 25, 2018
|
Is there a better workaround than downgrading |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
May 10, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
label
May 10, 2018
This comment has been minimized.
This comment has been minimized.
|
I'm happy to do some digging on this issue. But I'm not a Flow user. Can you share a repo with a minimal setup that exhibits the issue so I can see it in action? Thanks! |
stale
bot
removed
the
stale
label
May 11, 2018
feross
added
the
need more info
label
May 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Related to: #1045 |

kellyrmilligan commentedSep 13, 2017
I'd prefer not to eject, but the current setup with flow seems to be incomplete.
these two rules should be enabled to fully support the flow definitions:
https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-define-flow-type
and
https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-use-flow-type
I was lead to these by:
https://github.com/babel/babel-eslint#known-issues
in my setup, I am using latest babel-eslint as the parser, and built in flow stuff works. but if I try and do
then I seem to be out of luck.
thoughts?