-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event is not defined with flow type, any way to fix this without ejecting from standard? #984
Comments
Same issue here. A lot of undefined because of those rules. Any PR in the pipe? |
I'm facing the same problem :( |
What are the versions of your packages? eslint, flowtype plugin, standard, etc.? It would be great to have a small repo where we could reproduce the issue |
I was having a similar issue, getting a lot of |
@fbaiodias your solution works. Thanks |
Downgrading to What's going on here...? EDIT: scratch that... downgrading fixes the problems, the other problems I was having was not prefixing browser globals with |
Downgrading to Just for my understanding, is this flow type undef behavior due to an an issue with |
Also work for us with babel-eslint@7.2.1, tried to upgrade to babel-eslint@7.2.3 and it breaks again. |
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Uses babel-eslint and the flowtype plugin - https://standardjs.com/index.html#flow. babel-eslint must be kept at v.7.2.1 as later versions do not correctly identify flow types with the flowtype plugin and standard (see standard/standard#984)
Is there a better workaround than downgrading |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I'm happy to do some digging on this issue. But I'm not a Flow user. Can you share a repo with a minimal setup that exhibits the issue so I can see it in action? Thanks! |
Related to: #1045 |
I'd prefer not to eject, but the current setup with flow seems to be incomplete.
these two rules should be enabled to fully support the flow definitions:
https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-define-flow-type
and
https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-use-flow-type
I was lead to these by:
https://github.com/babel/babel-eslint#known-issues
in my setup, I am using latest babel-eslint as the parser, and built in flow stuff works. but if I try and do
then I seem to be out of luck.
thoughts?
The text was updated successfully, but these errors were encountered: