Introduce "warning" policy; change no-var to a warning #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@standard/team - can you take a look at this? |
|
I think warnings are a great way to check if a change has impact on newly written modules or existing ones with a high velocity of changes without having to worry about breakage to existing “finished” ones so big 👍 from me |
|
Thanks for the reviews, @mcollina and @mafintosh! |
|
Released as 16.0.1 |
|
Awesome work getting this out quickly! 🌟 |
|
Thanks @LinusU ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Explain the difference between errors and warnings in the FAQ. Prep for releasing 16.0.1.
Which issue (if any) does this pull request address?
#633
Is there anything you'd like reviewers to focus on?