Support node 11 #1597
Merged
Support node 11 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
We don't want to support Node.js 11 since it's no longer supported by Node.js itself, can you instead update the message? |
|
@LinusU While I agree that we don't want to officially promise support for Node 11, is there harm in letting it run in on that version if it works? |
|
Right, didn't really think about that 😄 I don't see why we should block it 👍 |
LinusU
approved these changes
Nov 11, 2020
|
🎉 Congrats on getting your first pull request landed! |
|
Released as 16.0.2 |
This was referenced Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
What changes did you make? (Give an overview)
Currently, if you try to run standard using node v11, the executable outputs:
Node 10.12.0 or greater is required. standard did not run.Since v11 is greater than v10.12.0, this change makes the behaviour consistent with the messaging!