test: separate internal/external

[theoludwig]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: Tests

What changes did you make? (Give an overview)

Separate the tests in 2 scripts : test-internal and test-external.

From @voxpelli :

That way the badging situation will be easier to decipher – for maintainers as well as users and contributors.

👍

Which issue (if any) does this pull request address?

Ref: #1663 (comment)

[voxpelli]

LGTM 👍

[theoludwig]

Before merging, we need to update the branch protection rules with these new workflows.

[voxpelli]

I'm 👍 on the changes

[voxpelli]

Random note: After this PR we should add 16.x to the test matrix

[LinusU]

Neat 👍

[theoludwig]

Random note: After this PR we should add 16.x to the test matrix

Agreed. I already added 16.x to the test matrix, is it fine or we should wait to do that after this PR ?

[voxpelli]

Random note: After this PR we should add 16.x to the test matrix

Agreed. I already added 16.x to the test matrix, is it fine or we should wait to do that after this PR ?

It’s fine I would say :)

[voxpelli]

@divlo Something else you want to get fixed before merging?

[theoludwig]

@divlo Something else you want to get fixed before merging?

Yes, test external with Node.js v16 is failing.
This is one of @feross repo that fails, see: feross/bitmidi.com#116.

[voxpelli]

@divlo lets remove 16.x from this PR then, merge this PR, and then open a new one for that specific one :) This fix is too good to sit around here ;)

[theoludwig]

@divlo lets remove 16.x from this PR then, merge this PR, and then open a new one for that specific one :) This fix is too good to sit around here ;)

Let's do that! 😎
I opened a separate PR to add Node.js v16 : #1703