Update dependencies and improve GitHub Actions CI configurations #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
|
Hey @toddbluhm! 👋 |
|
🎉 Congrats on getting your first pull request landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
dependabot.ymland seperate Commit lint in another workflow thannodejs+ Change theonevent so it only runs on push/pull_request on master branch..editorconfigto follow betterstandardeditor configIs there anything you'd like reviewers to focus on?
Currently we're running inside GitHub actions : linting, automated tests etc, on 3 version of Node.js
[10.x, 12.x, 14.x]but we're also running 3 timesLint the Commit Messagesbut this doesn't depend on the node.js version so we could seperate in another workflow setting file so it runs only once. That's why I seperate Commit lint in another workflow thannodejs, seecommitlint.yml. Also I changed theonevent so it only runs once and not twice as it was the case when we push and it is a PR.If everything is fine for you, we could release
ts-standard@10.0.0after this has been merged to master (up to you).Feel free to review my PR and tell me what changes you disagree etc.
Oh also, we could add Branch protection rules, so we can't merge a PR to master if there are not at least 1 approved review.