Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute --project path #269

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Conversation

lindluni
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

Added the ability for the --project flag to be an absolute path.

Which issue (if any) does this pull request address?

#268

Is there anything you'd like reviewers to focus on?

The existing implementation requires a relative path with the
`--project` flag. Updates the `_resolveTSConfigPath` function
to check if path is absolute before attempting to join it with
the `CURRENT_WORKING_DIRECTORY`.
@theoludwig theoludwig added the bug Something isn't working label Nov 21, 2022
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theoludwig theoludwig merged commit 8c74be2 into standard:master Nov 21, 2022
@lindluni lindluni deleted the project-flag branch December 15, 2022 07:45
@lindluni lindluni mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants