Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yelp - Assignment 2 #1

Open
standardcombo opened this issue Feb 15, 2015 · 1 comment
Open

Yelp - Assignment 2 #1

standardcombo opened this issue Feb 15, 2015 · 1 comment

Comments

@standardcombo
Copy link
Owner

/cc @codepath

@codepathreview
Copy link

👍 nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

  • For the restaurant cell, note that the subviews should be private and only updated in the Swift property observer.
  • Nice work specifying the Auto Layout constraints.
  • Connecting the filter view controller directly to a global filter settings is convenient, but the downside is if you cancel the filters, the values have already been saved. Consider defining a custom protocol to capture the filter change event.

This was a challenging assignment, congrats on completing it successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants