This repository has been archived by the owner on Oct 17, 2019. It is now read-only.
Fix initial specs. Single constraint and direct mapping. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okeefm
suggested changes
Apr 18, 2018
test/fixtures/spec/shr_fhir.txt
Outdated
| Value: boolean | ||
|
|
||
| EntryElement: PatientDirectMapEntry | ||
| Description: "Maps directly to the Patient resource (no profile needed)" | ||
| 0..1 ActiveFlag | ||
|
|
||
| Element: ActiveFlag |
There was a problem hiding this comment.
I don't think we need to define this element twice? The ActiveFlag element from above should be usable in PatientDirectMapEntry too. If we do want both of these elements to exist (for the different description, for example), we should change ActiveFlag to a different name, because they're both in the shr.fhir namespace. Right now, only one of these (the second one) is showing up.
There was a problem hiding this comment.
Ah, good point, if that's how this works. I'm afk for a bit, so feel to commit a fix and merge, otherwise I'll do it when I get back.
There was a problem hiding this comment.
(no need to have 2 different names for now, I just put in the directmap case so we don't forget about it)
okeefm
approved these changes
Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start with the single constraint, but I left the direct mapping as a case we should handle in the future.