Skip to content
This repository has been archived by the owner on Oct 17, 2019. It is now read-only.

Chained setters to support curation #9

Merged
merged 4 commits into from
Feb 23, 2018
Merged

Chained setters to support curation #9

merged 4 commits into from
Feb 23, 2018

Conversation

jgibson
Copy link
Member

@jgibson jgibson commented Feb 21, 2018

These are a batch of changes to support the curation study. It should not be merged yet because we'll want the #8 changes as well. Probably with built-in type handling.

@gregquinn2001
Copy link
Contributor

@jgibson could you provide a little more detail on these changes? When you added method chaining for setters, did you maintain backward compatibility with existing setters? So if we use the existing setters and ignore any return argument (since there wasn't one before), will our current code still work? Or maybe even more simply, did you change the names of the existing setters (whether they return an object or not now)?

@gregquinn2001
Copy link
Contributor

In the future, if you are planning to push changes for use by curation study and Flux notes, could you add Dan and I as reviewers like you add Chris? That way we know to look at the pull request.

@cmoesel
Copy link
Member

cmoesel commented Feb 23, 2018

@jgibson -- I just merged #8, which you indicated you were waiting on. Should I wait for this PR to be ready before bumping the es6-export version number and releasing?

@jgibson jgibson changed the title WIP: Changes to support curation Chained setters to support curation Feb 23, 2018
@jgibson
Copy link
Member Author

jgibson commented Feb 23, 2018

In preparation for Chris' upcoming shr-cli release here is a minor enhancement to add chained setters to the es6 class generator. In addition the modules sanity checking is now supported in by the es6 class generator.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cmoesel cmoesel merged commit 18d08a7 into master Feb 23, 2018
@cmoesel cmoesel deleted the curation branch February 23, 2018 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants