Updates Needed by IG Publisher #109
Conversation
This way the header and footer remain visible and the user doesn't get lost.
Needed by XHTML, else it gets improperly parsed.
|
Note that when you run the IG publisher, if you look at the QA file ( |
|
In general, all of this looks good. I do have a couple of questions about errors that appear in the console of the page when using it, though. On every page of the IG when I run it, I get this error:
This seems to be related to CORS. Is this a typical issue when running locally, or is this a new problem? Additionally, on the model doc page, all of these errors are shown: None of these seem to affect anything from what I can tell, but I want to ensure that these aren't an issue, and see if they need to be resolved. |
|
I just tested again with Additionally, when I ran on this branch, I got a result from the publisher of: But when I ran on Should we be concerned about the warnings that appear using this branch? Or are those only related to the issue you noted above? |
|
Right. Some console errors are due to running on the file system instead of HTTP. If you host it using an HTTP server, they'll go away. For example, on mac: Browsing to http://localhost:8000/index.html, I don't get any console errors:
Going to the modeldoc, however, I still get some:
The first two are issues w/ the modeldoc itself (outside the scope of this PR). The third may be introduced by this PR (since |
|
I'll look at those warnings. I thought we got those before too, but maybe not. If they're new, it's likely due to the igpublisher jar flagging things it didn't used to flag. I'll take a look and report back. |
|
OK. Some of these are valid warnings, but caused by issues in the CIMPL definitions (unrelated to this PR). It must be that the old IG Publisher jar didn't catch these. For example, this is an incorrect display value:
Some others, however, seem invalid -- but again, aren't really our issue. For example, this is flagged as a mismatch, but it looks fine to me:
Those are the only two types of warnings encountered (valid warnings about terminology mismatches and seemingly invalid warnings about terminology mismatches). |
|
I'm working on updates to the modeldoc code that will address the remaining issues. |
This contains the following changes in order to keep up w/ IG publisher process & requirements:
hrefvalue and unterminated HTML<head>tag. (Oops).<!--status-bar-->comment andigtool="footer"attribute per Grahame's instructions (here)