fix: chashes when disabling bug snag

standardnotes · Dec 22, 2020 · 69052a5 · 69052a5
1 parent 3d54a1b
commit 69052a5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/android/app/src/main/java/com/standardnotes/MainApplication.java b/android/app/src/main/java/com/standardnotes/MainApplication.java
@@ -81,7 +81,7 @@ public void onCreate() {
     SharedPreferences settings = getApplicationContext().getSharedPreferences("react-native", Context.MODE_PRIVATE);
     String bugsnagOptOut = settings.getString("bugsnagoptout", "false");
 
-    if (bugsnagOptOut.equals("true")) {
+    if (!bugsnagOptOut.equals("true")) {
       Bugsnag.start(this, config);
     }
 

diff --git a/ios/StandardNotes/AppDelegate.m b/ios/StandardNotes/AppDelegate.m
@@ -40,7 +40,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
   config.enabledBreadcrumbTypes = BSGEnabledBreadcrumbTypeNavigation | BSGEnabledBreadcrumbTypeLog
   | BSGEnabledBreadcrumbTypeUser | BSGEnabledBreadcrumbTypeState | BSGEnabledBreadcrumbTypeNavigation | BSGEnabledBreadcrumbTypeProcess;
 
-  if ([bugsnagOptOut isEqualToString:@"true"]) {
+  if (![bugsnagOptOut isEqualToString:@"true"]) {
     [Bugsnag startWithConfiguration:config];
   }
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "StandardNotes",
-  "version": "3.5.13",
-  "user-version": "3.5.13",
+  "version": "3.5.14",
+  "user-version": "3.5.14",
   "private": true,
   "license": "AGPL-3.0-or-later",
   "scripts": {

diff --git a/src/App.tsx b/src/App.tsx
@@ -134,7 +134,11 @@ export const App = (props: { env: 'prod' | 'dev'; bugsnagOptOut: boolean }) => {
 
   useEffect(() => {
     if (!__DEV__ && !props.bugsnagOptOut) {
-      Bugsnag.start();
+      try {
+        Bugsnag.start();
+      } catch {
+        console.error('Bugnsag failed to start');
+      }
     }
   }, [props.bugsnagOptOut]);
 

diff --git a/src/screens/Settings/Sections/CompanySection.tsx b/src/screens/Settings/Sections/CompanySection.tsx
@@ -54,7 +54,7 @@ export const CompanySection = (props: Props) => {
           'Changes will be refrected after an app restart.'
         );
       } catch {
-        application?.alertService.alert('Changing ');
+        application?.alertService.alert('An error occured. Please try again.');
       }
     },
     [application?.alertService, application?.deviceInterface]