This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Upgrade react native #429
Merged
Upgrade react native #429
+1,140
−1,161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielsvg
force-pushed
the
feature/upgrade-react-native
branch
from
82ea8c1
to
bd9a686
Compare
arielsvg
commented
May 4, 2021
| use_react_native!(:path => config["reactNativePath"]) | ||
| use_react_native!( | ||
| :path => config["reactNativePath"], | ||
| :hermes_enabled => false, |
There was a problem hiding this comment.
The Hermes iOS runtime is very new so I want to give it a good test run on the dev variant first
antsgar
approved these changes
May 4, 2021
antsgar
reviewed
May 4, 2021
|
I noticed a few component changes in this PR. Are these related to the upgrade, or general optimizations? If the latter, it would be good to separate from this PR, so that if we want to revert this commit (not an unlikely scenario), we can do so without reverting other unrelated changes. |
|
Hm that's a good point. They are related to the upgrade in that RN now logs an error (instead of a warning) when we use them in an unexpected way. But since it's a loose relation I'll take your suggestion and cut this PR down to size |
moughxyz
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.