fix: gradle version inconsistency #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to inconsistent gradle version detection, e.g. on F-Droid it is parsed as 7.2, while elsewhere it is probably 7.5.1. It seems that `packages/mobile/android/app/gradle` is not used in the build process. We'd better remove it.
proletarius101
force-pushed
the
fix-gradle-version-inconsistency
branch
from
d75e5aa
to
95e06d5
Compare
|
Sorry, doesn't look like anyone was tagged or assigned here. I'd be loath to merge this given that it's updates to a binary file we can't really see the contents of. Could you instead give us the location we can retrieve the same contents from, and we can make the change ourselves? |
I did't add files. I deleted those files |
|
Ah ok. Will merge this then once we take care of a few CI things related to mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to inconsistent gradle version detection, e.g. on F-Droid it is parsed as 7.2, while elsewhere it is probably 7.5.1.
It seems that
packages/mobile/android/app/gradleis not used in the build process. We'd better remove it.