Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin
Noticed that there were errors on the server side coming from the
@standardnotes/features
package caused by the content type comparisons. So I decided to replace the oldContentType
usage with new one on theapp
What this PR does
param: ContentType
toparam: string
as the oldContentType
was essentially just a string alias. It did not safe-guard the content type on runtime - just a dev env helper.ContentType.File
toContentType.TYPES.File
What this PR does not
How to use ContenType
ContentType
is a proper domain value object now which safe-guards its definition during runtime. Here is how to use it: