Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Editing large notes (greater than 1.5MB) will result in more optimized syncing, in which changes are saved locally immediately, but sync with the server less frequently (roughly every 30 seconds rather than after every change). #2768

Merged
merged 35 commits into from Jan 20, 2024
Merged

feat: Editing large notes (greater than 1.5MB) will result in more optimized syncing, in which changes are saved locally immediately, but sync with the server less frequently (roughly every 30 seconds rather than after every change). #2768

merged 35 commits into from Jan 20, 2024

Conversation

amanharwara
Copy link
Member

No description provided.

amanharwara and others added 21 commits January 9, 2024 23:37
@amanharwara
chore: sync when window is blurred
a78d88f
@amanharwara
chore: sync when editor loses focus
ce699b7
@amanharwara
refactor: separate local & remote save debounce amounts
2367e8f
@amanharwara
Merge branch 'main' into sync-improvements
f86d9cd
@amanharwara
chore: fix issues
725ebd9
@amanharwara
refactor: make sure local save is resolved before remote save
472ed18
@amanharwara
Merge branch 'main' into sync-improvements
9b6ccbe
@amanharwara
refactor: show waiting status
75e92b4
@amanharwara
fix: sync locally on local save
ac10fc6
@amanharwara
Revert "fix: sync locally on local save"
5352491 
This reverts commit ac10fc6.
@amanharwara
fix: persist mutated item payload on local save
ad2752e
@amanharwara
Merge branch 'main' into sync-improvements
0b25119
@amanharwara
fix: test type
e2f63cf
@amanharwara
refactor: note status indicator ui
c640ebc
@amanharwara
fix: status on sync
613136a
@moughxyz
refactor: local only sync of large item
9d92e9c
@moughxyz
fix: release lock
37fce73
@moughxyz
fix: handle race where large note sync occurs just before local mutat…
d479bda 
…e and thus another sync would not have been queued
@amanharwara
Merge branch 'main' into sync-improvements
f2ebe39
@amanharwara
chore: popover max-width
43b2797
@amanharwara
refactor: trigger sync on action instead of editor blur
1528e92
@amanharwara amanharwara marked this pull request as ready for review January 19, 2024 16:37
@amanharwara amanharwara changed the title chore: sync when window is blurred refactor: status indicator and sync on window blur and note actions Jan 19, 2024
@moughxyz moughxyz changed the title refactor: status indicator and sync on window blur and note actions feature: Editing large notes (greater than 1.5MB) will result in more optimized syncing, in which changes are saved locally immediately, but sync with the server less frequently (roughly every 30 seconds rather than after every change). Jan 19, 2024
@moughxyz moughxyz changed the title feature: Editing large notes (greater than 1.5MB) will result in more optimized syncing, in which changes are saved locally immediately, but sync with the server less frequently (roughly every 30 seconds rather than after every change). feat: Editing large notes (greater than 1.5MB) will result in more optimized syncing, in which changes are saved locally immediately, but sync with the server less frequently (roughly every 30 seconds rather than after every change). Jan 19, 2024
@amanharwara amanharwara merged commit 396ee3f into main Jan 20, 2024
8 checks passed
@amanharwara amanharwara deleted the sync-improvements branch January 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amanharwara @moughxyz