Bugfix: Fix Simplenote importer not titling multi-line documents #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanharwara
requested changes
Jan 26, 2024
packages/ui-services/src/Import/SimplenoteConverter/SimplenoteConverter.ts
Outdated
Show resolved
Hide resolved
mmorella-dev
added a commit
to mmorella-dev/standardnotes-app
that referenced
this pull request
Jan 26, 2024
From standardnotes#2798 (comment) Co-authored-by: Aman Harwara <amanharwara@protonmail.com>
mmorella-dev
force-pushed
the
fix-simplenote-titles
branch
2 times, most recently
from
58215ee
to
ba5e69d
Compare
mmorella-dev
force-pushed
the
fix-simplenote-titles
branch
2 times, most recently
from
ec7ec1e
to
a7f090f
Compare
|
@amanharwara Thanks for the suggestions! I've made some stylistic changes in-line with your suggestions, and modified the test data to include a note with more than 2 lines. In my testing, this case fails on the unpatched version (79951c3) and passes after my changes (27e7815). (Sorry for the noise with all the force-pushes. I can get a bit carried away making history "perfect".) |
SimplenoteConverter will now parse a title for any note with multiple lines, not just those with exactly two. Adds a string helper function splitAtFirst.
mmorella-dev
force-pushed
the
fix-simplenote-titles
branch
from
a7f090f
to
27e7815
Compare
|
(okay, one more...) |
|
@amanharwara Build and tests passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimplenoteConverter has a bug which causes it to only parse a title in notes which have exactly two lines. This is one of the issues addressed by jamesgecko/simple-to-standard.
Example data:
{ "activeNotes": [ { "id": "bb33231fc77e49e9b2f66b5d07b1159d", "content": "Title One\r\nThis note has a title and one line of body!", "..." }, { "id": "53c79c16-896f-43e5-80e5-a0f92c85330d", "content": "Title Two\r\nThis note has a title and...\r\nmultiple lines...\r\nof body!", "..." }, { "id": "1b105f4d24534d329ca8d99439219685", "content": "\r\nThis note has only a body!", "..." }, ], "..." }Current behavior: the second note is given a title.
This PR fixes that issue by replacing an instance of String.prototype.split with a new helper function, splitOnce, which splits a string only on the first occurrence of the delimiter.
After fix: multi-line notes are titled correctly.
