Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable e2e test for already existing members of shared vaults #2396

Merged
merged 1 commit into from Aug 8, 2023
Merged

chore: enable e2e test for already existing members of shared vaults #2396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/services/src/Domain/VaultInvite/VaultInviteService.ts
View file
Open in desktop
Expand Up @@ -189,6 +189,9 @@ export class VaultInviteService
sharedVaultContacts: contacts,
permission,
})
if (result.isFailed()) {
return Result.fail(result.getError())
}

void this.notifyEvent(VaultInviteServiceEvent.InviteSent)

Expand Down
2 changes: 1 addition & 1 deletion packages/snjs/mocha/vaults/invites.test.js
View file
Open in desktop
Expand Up @@ -224,7 +224,7 @@ describe('shared vault invites', function () {
await deinitContactContext()
})

it.skip('should fail to invite user if already member of shared vault', async () => {
it('should fail to invite user if already member of shared vault', async () => {
const { sharedVault, contact, deinitContactContext } = await Collaboration.createSharedVaultWithAcceptedInvite(
context,
)
Expand Down